feat: Login with Internet Identity#495
Open
adamspofford-dfinity wants to merge 16 commits intomainfrom
Open
Conversation
raymondk
reviewed
Apr 10, 2026
raymondk
reviewed
Apr 10, 2026
raymondk
reviewed
Apr 20, 2026
| } | ||
|
|
||
| pub(crate) async fn exec(ctx: &Context, args: &IiArgs) -> Result<(), IiError> { | ||
| ctx.dirs |
Contributor
There was a problem hiding this comment.
We can have a follow up PR to do the same thing in the HSM and in identity new
raymondk
reviewed
Apr 20, 2026
| #[derive(Debug, Subcommand)] | ||
| pub(crate) enum Command { | ||
| Hsm(hsm::HsmArgs), | ||
| #[command(hide = true)] |
Contributor
There was a problem hiding this comment.
TODO comment to say that we will unhide it when the feature is public?
raymondk
reviewed
Apr 20, 2026
| let mut headers = HeaderMap::new(); | ||
| headers.insert( | ||
| header::ACCESS_CONTROL_ALLOW_ORIGIN, | ||
| HeaderValue::from_static("*"), |
Contributor
There was a problem hiding this comment.
Shouldn't this be limited to the URL that was opened?
raymondk
reviewed
Apr 20, 2026
|
|
||
| use crate::commands::identity::StorageMode; | ||
|
|
||
| /// Link an Internet Identity to a new identity |
Contributor
There was a problem hiding this comment.
Maybe we can add more details here in the expanded help about how this can be useful?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.